Remove EL6 from st2chatops #153
Merged
+3
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
suggested changes
Jul 2, 2020
There was a problem hiding this comment.
That looks good!
The following sysvinit service script is EL6-only and could be removed now:
https://github.com/StackStorm/st2chatops/blob/master/rpm/st2chatops.init
Additionally, rpm spec https://github.com/StackStorm/st2chatops/blob/master/rpm/st2chatops.spec needs a bit of cleanup. With el6 removal, all EL platforms we support are systemd now and so some logic in that spec could be simplified.
Would be great to have some better description for the PR. It's history and context that might be very helpful in the future.
24 tasks
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 6 / RHEL 6 is to be fully deprecated. Remove the EL6 specific code and builds. As all EL distributions support systemd, remove the st2chatops init.d service definition.